Add ArgoCD sync options to prevent premature pruning of bootstrap deployment #127
Conversation
HappyTetrahedron
force-pushed
the
feat/argocd-annotations
branch
from
1c45f18
to
4e3831c
Compare
| @@ -22,11 +22,13 @@ func createApplicationControllerStatefulSet(ctx context.Context, clientset *kube | |||
| for k, v := range argoLabels { | |||
| labels[k] = v | |||
| } | |||
| annotations := argoAnnotations | |||
There was a problem hiding this comment.
Is the underlying map modified by the client? The labels above are copied so i'm not sure here if that is also needed.
There was a problem hiding this comment.
As far as I could see, the labels are copied because there are some additional labels being inserted as literals (line 18ff) and then the argoLabels map is effectively merged into that. I'm not doing that with the annotations, so I figured the copying wouldn't be necessary. I don't see why the client would modify the map.
There was a problem hiding this comment.
In Go slices and maps are passed by reference, unlike the other types. and i do wonder what the client does with the reference since the client updates the given object with the object returned by the cluster
With the new setup, the bootstrap deployment is at some point deleted (to be replaced by the operator-managed one). However, this has to happen after the operator-managed ArgoCD is deployed. To prevent premature pruning, the bootstrap deployment is set to not be auto-pruned. A post-sync job in the ArgoCD component will remove these annotations at the appropriate time.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog