Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for ArgoCD operator-managed deployments and do not interfere #125

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Check for ArgoCD operator-managed deployments and do not interfere #125

merged 2 commits into from
Jun 30, 2023

Conversation

HappyTetrahedron
Copy link
Contributor

@HappyTetrahedron HappyTetrahedron commented Jun 29, 2023 •
edited
Loading

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the enhancement New feature or request label Jun 29, 2023
@HappyTetrahedron HappyTetrahedron marked this pull request as draft June 29, 2023 12:17
@HappyTetrahedron HappyTetrahedron marked this pull request as ready for review June 29, 2023 16:03
simu
simu approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM

@HappyTetrahedron HappyTetrahedron merged commit 6ac4f8d into master Jun 30, 2023
@HappyTetrahedron HappyTetrahedron deleted the feat/argocd-operato branch June 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HappyTetrahedron @simu