Fix multi-team-awareness check in ArgoApp() helper
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/argo-app-team-aware
branch
from
217debd to
e659d03
Compare
NOTE: We'll need to update all multi-team and multi-instance aware components to pass `base=<component-name>` when calling this function.
simu
force-pushed
the
fix/argo-app-team-aware
branch
from
e659d03 to
d4d13ec
Compare
4 tasks
DebakelOrakel
approved these changes
Feb 21, 2025
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: We'll need to update all multi-team and multi-instance aware components to pass
base=<component-name>when calling this function.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.