(feat) dry run: helm charts #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianlucam76
force-pushed
the
disable-caching
branch
from
d92083a to
035cb56
Compare
Before this PR, Sveltos' DryRun mode wrt Helm charts had limitations:
- Helm Chart Upgrades and Removals: Sveltos could detect whether a Helm chart
would be upgraded or removed.
- Identical Chart Versions: If the deployed and proposed Helm chart versions were
the same, Sveltos reported no changes, even if the Helm values differed.
This PR enhances Sveltos' DryRun mode by:
- **Detecting Value Differences**: When the deployed and proposed Helm chart
versions are identical, Sveltos now compares the Helm values used in deployment
with those proposed in the profile.
- **Detailed Diff Reporting**: If differences are found, Sveltos provides a detailed
diff of the values, highlighting specific changes:
```
- action: Update Values
chartName: kyverno-latest
chartVersion: v3.2.6
message: |
--- deployed
+++ proposed
@@ -1,8 +1,6 @@
admissionController:
- replicas: 3
+ replicas: 5
backgroundController:
- replicas: 1
+ replicas: 3
cleanupController:
replicas: 1
-reportsController:
- replicas: 1
```
gianlucam76
force-pushed
the
disable-caching
branch
from
035cb56 to
f575e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, Sveltos' DryRun mode wrt Helm charts had limitations:
This PR enhances Sveltos' DryRun mode by:
Detecting Value Differences: When the deployed and proposed Helm chart versions are identical, Sveltos now compares the Helm values used in deployment with those proposed in the profile.
Detailed Diff Reporting: If differences are found, Sveltos provides a detailed diff of the values, highlighting specific changes: