Docker Login Improvements (#394)

Previously the Docker Login step in many of the workflows was executed regardless of whether it was necessary. This would have been find except that the required secrets were not available in PRs from forks. This change removes the Docker Login steps from where it is not necessary and puts a guard on its execution in workflows that are run as part of PRs. Signed-off-by: Ben Hale <bhale@vmware.com>
projectriff · Oct 14, 2020 · 03dd09e · 03dd09e
1 parent debec23
commit 03dd09e
Show file tree

Hide file tree

Showing 15 changed files with 30 additions and 16 deletions.
diff --git a/.github/workflows/create-builder.yml b/.github/workflows/create-builder.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/minimal-labels.yml b/.github/workflows/minimal-labels.yml
@@ -1,6 +1,6 @@
 name: Minimal Labels
 "on":
-    pull_request_target:
+    pull_request:
         types:
             - synchronize
             - reopened

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,6 +1,6 @@
 name: Tests
 "on":
-    pull_request_target: {}
+    pull_request: {}
     push:
         branches:
             - main
@@ -10,7 +10,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-bellsoft-liberica.yml b/.github/workflows/update-bellsoft-liberica.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-build-image.yml b/.github/workflows/update-build-image.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-command-function.yml b/.github/workflows/update-command-function.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-draft-release.yml b/.github/workflows/update-draft-release.yml
@@ -13,7 +13,8 @@ jobs:
               uses: release-drafter/release-drafter@v5
               env:
                 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-gradle.yml b/.github/workflows/update-gradle.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-java-function.yml b/.github/workflows/update-java-function.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-leiningen.yml b/.github/workflows/update-leiningen.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-maven.yml b/.github/workflows/update-maven.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-node-function.yml b/.github/workflows/update-node-function.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-nodejs.yml b/.github/workflows/update-nodejs.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-sbt.yml b/.github/workflows/update-sbt.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}

diff --git a/.github/workflows/update-streaming-http-adapter.yml b/.github/workflows/update-streaming-http-adapter.yml
@@ -9,7 +9,8 @@ jobs:
         runs-on:
             - ubuntu-latest
         steps:
-            - name: Docker login gcr.io
+            - if: ${{ github.event_name != 'pull_request' || ! github.event.pull_request.head.repo.fork }}
+              name: Docker login gcr.io
               uses: docker/login-action@v1
               with:
                 password: ${{ secrets.RIFF_GCLOUD_SERVICE_ACCOUNT_KEY }}