Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cookiecutter #2421

Merged
merged 4 commits into from
Oct 25, 2024
Merged

remove cookiecutter #2421

merged 4 commits into from
Oct 25, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 25, 2024

As discussed in #2331, there is no need to have the cookiecutter stuff for autogenerating a project structure. This removes the folder, references in the docs, and dependency in the toml file. This made the entire main.py file redundant as far as I can tell, so I got rid of that as well.

I favor removal over deprecation because MESA 3 allows us to remove. Otherwise, we commit ourselves to maintaining this in MESA 3.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +0.6% [-0.7%, +1.8%] 🔵 +0.4% [+0.2%, +0.6%]
BoltzmannWealth large 🔵 +1.2% [+0.8%, +1.6%] 🔵 +0.1% [-1.4%, +1.5%]
Schelling small 🔵 -0.3% [-0.9%, +0.2%] 🔵 -0.3% [-0.7%, -0.0%]
Schelling large 🔵 +0.3% [-0.8%, +1.4%] 🔵 +0.7% [-0.4%, +1.9%]
WolfSheep small 🔵 +0.6% [+0.4%, +0.8%] 🔵 +1.8% [+1.6%, +2.0%]
WolfSheep large 🔵 +0.9% [+0.2%, +1.4%] 🔵 +1.1% [+0.1%, +2.3%]
BoidFlockers small 🔵 -1.3% [-1.8%, -0.8%] 🔵 -1.8% [-2.4%, -1.3%]
BoidFlockers large 🔵 -1.7% [-2.5%, -0.6%] 🔵 -2.6% [-3.2%, -2.1%]

@quaquel quaquel requested review from jackiekazil and EwoutH October 25, 2024 15:28
@quaquel quaquel merged commit 1d98560 into projectmesa:main Oct 25, 2024
11 of 12 checks passed
@EwoutH EwoutH added the breaking Release notes label label Oct 26, 2024
@quaquel quaquel deleted the remove_cookiecutter branch October 30, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants