-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff basic examples #2370
Ruff basic examples #2370
Conversation
Performance benchmarks:
|
do you mind if I contribute to this directly by fixing the various outstanding issues? |
Normally, no, but in this case I prefer merging this as is and doing follow-up PRs other issues. This PR is now neat and atomic, and you can just remove that added line in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think it's already much better now, acknowledge not updating docstrings in this PR, but should be done in the future
aeac384
to
5184c93
Compare
Fix: - N803 Argument name should be lowercase: 1 occurrence - N806 Variable in function should be lowercase: 2 occurrences
- Only exclude examples/advanced from ruff, to start running ruff on the basic examples. - Ignore docstring errors in the example folder. Both can be revisited in the future.
5184c93
to
ffe565b
Compare
Run ruff and ruff format on the basic examples. Follow-up on #2365, as requested.
I fixed all the non-docstring errors, but there are still 56 docstring errors left:
__init__
— 4 occurrences__init__
— 3 occurrencesFor now we ignore them, but they can be unignored later if preferred.
Also update the
pyproject.toml
to enforce this (aeac384):