Add radius argument to NetworkGrid.get_neighbors() #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason get_neighborhood() did have the radius argument, but get_neighbors() did not have it in the NetworkGrid. This commit resolves that inconsistency and allows get_neighbors() to take a radius as input and return the agents in that radius. Tests are included.
rht
approved these changes
Jan 20, 2024
|
Can't be merged before 2.2.2. |
|
Thanks, agree shouldn't be included (doesn't break anything though). We can merge it to the main branch though, it's the development branch. For 2.2.2 we can create a maintenance branch from 2.2.1 and cherry pick what we want in there. |
|
Needs to notify @jackiekazil that we are doing a branch with cherry picks for a patch release, because #1951 happened. |
|
RE: #1951 - I am okay if we change the versioning process -- for the manual build - the version was being pulled from the init ... we can change the process. I just want to insure that both a manual build and an automated build would work. If the auto build failed for some reason, the manual would be the back up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
get_neighborhood()did have theradiusinput argument, butget_neighbors()did not have it in the NetworkGrid. This commit resolves that inconsistency and allowsget_neighbors()to take a radius as input and return the agents in that radius. Tests are included.