make mesa runable without some dependencies #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
==========================================
- Coverage 79.92% 79.45% -0.47%
==========================================
Files 15 15
Lines 1270 1285 +15
Branches 277 285 +8
==========================================
+ Hits 1015 1021 +6
- Misses 216 225 +9
Partials 39 39 ☔ View full report in Codecov by Sentry. |
Corvince
force-pushed
the
feat/less-dependencies
branch
from
757993f to
30803c1
Compare
rht
approved these changes
Jan 9, 2024
rht
reviewed
Jan 9, 2024
| import itertools | ||
| import types | ||
| from functools import partial | ||
|
|
||
| import pandas as pd | ||
| with contextlib.suppress(ImportError): |
There was a problem hiding this comment.
Reading https://stackoverflow.com/questions/34566806/why-use-contextlib-suppress-as-opposed-to-try-except-with-pass, I suppose that using contextlib.suppress is more concise than try-except.
|
It seems that the dependencies in Solara ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with Jupyter Lite to create a first version of a Netlogo Web-like experience, where users can try out some models on a statically hosted webpage.
However, Pyodide (the underlying tech) needs either pure python packages or specialized wheels. Mesa itself is pure python, but it depends on mesa-viz-tornado, which depends on tornado, which is not yet compatible with Pyodide. I was trying to install mesa without dependencies, but the way it is currently build it requires mesa_viz_tornado to be present to import mesa.
This PR removes that hard dependency by only trying to import the module. So if users don't use the tornado backend they don't need to have that dependency installed.
I did the same for pandas, which is only used for converting the output of the datacollector and networkx, which is only used for NetworkGrid.
The other dependencies are either already only used on access or an integral part of mesa.