Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ColorCard layout #1876

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Improve ColorCard layout #1876

merged 2 commits into from
Nov 17, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Nov 15, 2023

Before:
2023-11-14T20:08:40,531825972-05:00
After:
2023-11-14T20:14:17,298818060-05:00

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f2f4d1e) 77.10% compared to head (816ae19) 77.10%.

Files Patch % Lines
mesa/experimental/jupyter_viz.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1876   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          15       15           
  Lines         974      974           
  Branches      213      213           
=======================================
  Hits          751      751           
  Misses        195      195           
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tpike3
tpike3 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3
Copy link
Member

tpike3 commented Nov 16, 2023

Could you squash your commits please

@rht
Copy link
Contributor Author

rht commented Nov 16, 2023

You could do squash and merge.

@tpike3 tpike3 merged commit 6d5cb67 into projectmesa:main Nov 17, 2023
12 of 13 checks passed
@rht rht deleted the solara-viz branch November 17, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpike3 tpike3 tpike3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rht @tpike3