check if positions values are tuples #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskarb
force-pushed
the
accept-tuple-arg
branch
2 times, most recently
from
55b9229 to
237b2ce
Compare
maskarb
force-pushed
the
accept-tuple-arg
branch
from
237b2ce to
f813875
Compare
rht
reviewed
Oct 8, 2023
| return wrapped_function(grid_instance, [positions]) | ||
| else: | ||
| return wrapped_function(grid_instance, positions) | ||
| if len(positions) == 2 and not isinstance(positions[0], tuple): |
There was a problem hiding this comment.
This makes more sense, because the previous code mistakenly detects ((1, 2), (2, 3)) as [positions].
rht
approved these changes
Oct 8, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1832 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 15 15
Lines 881 881
Branches 186 186
=======================================
Hits 717 717
Misses 141 141
Partials 23 23
☔ View full report in Codecov by Sentry. |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1831
Add extra check to the
accept_tuple_argumentwrapper. Ifpositionsis a tuple of tuples of length 2, then theiter_cell_list_contentsraises a TypeError.Example, given a cell_list of
((0, 98), (1, 99)), this will unpack herex, y in cell_listasx = (0, 98) and y = (1, 99).