Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for select input type #1779

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

rlskoeser
Copy link
Contributor

Add support for solara.Select for model input parameters, per #1777

I'd be glad to draft documentation or add more detail to one of the tutorials about supported input types, but not sure where to add that.

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.19% ⚠️

Comparison is base (24a1df3) 80.29% compared to head (d193f97) 80.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
- Coverage   80.29%   80.11%   -0.19%     
==========================================
  Files          15       15              
  Lines         878      880       +2     
  Branches      187      188       +1     
==========================================
  Hits          705      705              
- Misses        152      154       +2     
  Partials       21       21              
Files Changed Coverage Δ
mesa/experimental/jupyter_viz.py 20.14% <0.00%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht rht merged commit cedbefb into projectmesa:main Aug 26, 2023
@rht
Copy link
Contributor

rht commented Aug 26, 2023

Merged, thank you @rlskoeser !

@rht
Copy link
Contributor

rht commented Aug 26, 2023

I'd be glad to draft documentation or add more detail to one of the tutorials about supported input types, but not sure where to add that.

The place to add documentation should be the docstring of make_user_input, so that it is automatically displayed in readthedocs.io in the future.

As with tutorial, maybe in an example in https://github.com/projectmesa/mesa-examples that has yet to be ported to Solara. There is pd_grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants