Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README pic to remove line on left side #1763

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix README pic to remove line on left side #1763

merged 1 commit into from
Aug 17, 2023

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Aug 12, 2023

simple fix, replacing README pic for a better one

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e2c407f) 80.68% compared to head (b0f5665) 80.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1763   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files          15       15           
  Lines         870      870           
  Branches      184      186    +2     
=======================================
  Hits          702      702           
  Misses        147      147           
  Partials       21       21           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht
Copy link
Contributor

rht commented Aug 12, 2023

Too much whitespace between the plots. I can't really "test" this PR on narrow screen because in the RTD, https://mesa--1763.org.readthedocs.build/en/1763/ the image is hardcoded to projectmesa/main: https://github.com/tpike3/mesa/blob/5cdf9f0ef007279be4555733ba884495a70a9197/README.rst?plain=1#L19.

@tpike3
Copy link
Member Author

tpike3 commented Aug 16, 2023

Too much whitespace between the plots. I can't really "test" this PR on narrow screen because in the RTD, https://mesa--1763.org.readthedocs.build/en/1763/ the image is hardcoded to projectmesa/main: https://github.com/tpike3/mesa/blob/5cdf9f0ef007279be4555733ba884495a70a9197/README.rst?plain=1#L19.

Updated with new one, let me know what you think

@rht
Copy link
Contributor

rht commented Aug 17, 2023

LGTM

@rht rht merged commit 1ee5cda into projectmesa:main Aug 17, 2023
@tpike3 tpike3 added this to the Release 2.1.2 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants