Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Update to use Solara viz #1757

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Docker: Update to use Solara viz #1757

merged 1 commit into from
Sep 19, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Aug 7, 2023

Not yet tested. Note that the current Docker setup is broken because the examples folder is now gone (moved to mesa-examples repo).

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ccde77b) 81.79% compared to head (394d511) 81.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1757   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files          15       15           
  Lines         890      890           
  Branches      191      191           
=======================================
  Hits          728      728           
  Misses        138      138           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpike3
Copy link
Member

tpike3 commented Aug 10, 2023

Not yet tested. Note that the current Docker setup is broken because the examples folder is now gone (moved to mesa-examples repo).

You are absolutely correct, thanks for catching this!

@rht rht marked this pull request as ready for review September 9, 2023 15:29
@rht
Copy link
Contributor Author

rht commented Sep 9, 2023

@tpike3 this is ready to merge. I have tested locally.

@rht
Copy link
Contributor Author

rht commented Sep 12, 2023

@tpike3 ?

1 similar comment
@rht
Copy link
Contributor Author

rht commented Sep 19, 2023

@tpike3 ?

@rht rht mentioned this pull request Sep 19, 2023
@tpike3 tpike3 merged commit 2be2f05 into projectmesa:main Sep 19, 2023
@tpike3
Copy link
Member

tpike3 commented Sep 19, 2023

Sorry for the delay so how I missed this one

@tpike3 tpike3 added this to the Release 2.1.2 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants