perf: Access grid only once #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 20 20
Lines 1302 1302
Branches 246 246
=======================================
Hits 942 942
Misses 325 325
Partials 35 35
☔ View full report in Codecov by Sentry. |
|
On the Schelling performance I also opened JuliaDynamics/ABMFrameworksComparison#57 which could give us a 3-5x advantage |
tpike3
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our current implementation we access the grid first to check if the cell is empty and then a second time to iterate over the contents. Inlining the check and using the walrus operator allows to access the content only once.
Using the ABM framework comparison i get the following speedups on my laptop for the Schelling model.