fix: Remove race condition when pause button sometimes doesn't work #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a typo: on_play should be on_playing. As such, the playing=playing.value argument of widgets.Play and `playing.value = True` inside `on_play_value` may sometimes cancel each other.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
+ Coverage 72.29% 72.35% +0.05%
==========================================
Files 20 20
Lines 1303 1302 -1
Branches 246 246
==========================================
Hits 942 942
+ Misses 326 325 -1
Partials 35 35
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo: on_play should be on_playing. As such, the playing=playing.value argument of widgets.Play and
playing.value = Trueinsideon_play_valuemay sometimes cancel each other.With this PR, the play/pause should be more robust.