breaking: Remove UserSettableParameter #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rht
force-pushed
the
rm_usersettableparam
branch
3 times, most recently
from
f29c2c2 to
3cca12d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
- Coverage 80.52% 80.20% -0.33%
==========================================
Files 18 18
Lines 1248 1192 -56
Branches 240 225 -15
==========================================
- Hits 1005 956 -49
+ Misses 205 201 -4
+ Partials 38 35 -3
☔ View full report in Codecov by Sentry. |
rht
force-pushed
the
rm_usersettableparam
branch
from
3cca12d to
20f7d0f
Compare
Corvince
approved these changes
Jun 17, 2023
tpike3
reviewed
Jun 17, 2023
tests/test_visualization.py
Outdated
| from mesa.visualization.UserParam import ( | ||
| NumberInput, | ||
| Slider, | ||
| ) | ||
| from tests.test_batchrunner import MockAgent |
There was a problem hiding this comment.
I think I am missing some here on the conflict. If we are importing MockAgent shouldn't it be tests.test_batch_run import MockAgent?
There was a problem hiding this comment.
That was the code from before BatchRunner was removed.
rht
force-pushed
the
rm_usersettableparam
branch
from
20f7d0f to
d680c3b
Compare
|
Merge conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.