Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding grass patches to WolfSheep model #161

Closed
wants to merge 1 commit into from
Closed

Adding grass patches to WolfSheep model #161

wants to merge 1 commit into from

Conversation

davpaez
Copy link
Contributor

@davpaez davpaez commented Jul 14, 2015

This solves #34

I tested this against the netlogo model, and it seems to behave very similarly.

- adding parameters: grass_regrowth_time
- reordering of arguments for WolfSheepPredation model
- creating custom activation schedule by breed. This was done in order to emulate the procedures in the original model from netlogo
- modifying methods for the case when grass=True
- both wolves and sheep can die
- they only reproduce if they are still living
- added run_model method to show results in console, since I could get the visualization to run
@dmasad dmasad self-assigned this Jul 14, 2015
@dmasad
Copy link
Member

dmasad commented Jul 14, 2015

Awesome! Looks pretty good! Just adding a couple notes. Do you want to take a shot at adding the grass to the visualization as well?

self.running = True

def step(self):
self.schedule.step()
print([self.schedule.time,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printing should be optional (e.g. with a verbose parameter) since otherwise it clutters up the command line during batch runs, visualization, etc. This is fine for debugging, but best practice is probably to use a data collector to keep track of these stats.

@dmasad
Copy link
Member

dmasad commented Sep 12, 2015

Additions made in #169.

@dmasad dmasad closed this Sep 12, 2015
@jackiekazil jackiekazil added this to the Unknown milestone milestone Nov 22, 2020
EwoutH added a commit that referenced this pull request Oct 12, 2024
This commit reverts PR #161 projectmesa/mesa-examples#161

That PR assumed that time advancement would be done automatically, like proposed in #2223

We encountered some underlying issues with time, which we couldn't resolve in time.
EwoutH added a commit that referenced this pull request Oct 12, 2024
This reinstates PR #161 after the previous revert.
EwoutH added a commit that referenced this pull request Oct 12, 2024
This commit reverts PR #161 projectmesa/mesa-examples#161

That PR assumed that time advancement would be done automatically, like proposed in #2223

We encountered some underlying issues with time, which we couldn't resolve in time.
EwoutH added a commit that referenced this pull request Oct 12, 2024
This reinstates PR #161 after the previous revert.
EwoutH added a commit to EwoutH/mesa that referenced this pull request Oct 15, 2024
…lity (projectmesa#170)

This commit reverts PR projectmesa#161 projectmesa/mesa-examples#161

That PR assumed that time advancement would be done automatically, like proposed in projectmesa#2223

We encountered some underlying issues with time, which we couldn't resolve in time.
EwoutH added a commit to EwoutH/mesa that referenced this pull request Oct 15, 2024
…lity (projectmesa#170)

This commit reverts PR projectmesa#161 projectmesa/mesa-examples#161

That PR assumed that time advancement would be done automatically, like proposed in projectmesa#2223

We encountered some underlying issues with time, which we couldn't resolve in time.
EwoutH added a commit to EwoutH/mesa that referenced this pull request Oct 15, 2024
…onality

This reinstates PR projectmesa#161 after the previous revert.
EwoutH added a commit to EwoutH/mesa that referenced this pull request Oct 15, 2024
…onality

This reinstates PR projectmesa#161 after the previous revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants