Adding Pyplot visualization #1139

vineetvermait · 2022-01-21T05:43:35Z

This visualization allows the developer to add any pyplot visualization. removes all dependencies on the js components

EwoutH · 2022-01-22T09:04:10Z

This looks awsome! Could you add a few example screenshots?

mesa/visualization/modules/PyPlotVisualization.py

vineetvermait · 2022-01-24T03:01:18Z

Updated the code, Added Documentation

mesa/visualization/modules/PyPlotVisualization.py

codecov · 2022-01-24T13:02:39Z

Codecov Report

Merging #1139 (c9e2694) into main (4a79705) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
+ Coverage   89.30%   89.48%   +0.18%     
==========================================
  Files          19       20       +1     
  Lines        1253     1294      +41     
  Branches      256      255       -1     
==========================================
+ Hits         1119     1158      +39     
- Misses         98      100       +2     
  Partials       36       36

Impacted Files	Coverage Δ
mesa/visualization/modules/PyPlotVisualization.py	`100.00% <100.00%> (ø)`
mesa/visualization/modules/__init__.py	`100.00% <100.00%> (ø)`
mesa/space.py	`94.91% <0.00%> (-1.00%)`	⬇️
mesa/batchrunner.py	`92.28% <0.00%> (+0.72%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a79705...c9e2694. Read the comment docs.

tpike3

This is great @vineetvermait, thanks! I requested a few changes. A major concern is ensuring the graphs render cleanly.

docs/tutorials/adv_tutorial.ipynb

docs/tutorials/adv_tutorial.rst

vineetvermait · 2022-01-27T06:19:17Z

Fixed

tpike3

@vineetvermait could you please correct the failing checks and squash your commits so it is one commit.

@rht Can you please give it a second look

Then it should be good to merge

rht · 2022-01-28T00:59:53Z

The CI fails because matplotlib is not installed.
TODO:

inside PyPlotVisualization.py, do a try import matplotlib. If this fail raises an error and say that the optional dependency matplotlib is missing
in setup.py, in extras_require, in dev, add matplotlib.

mesa/visualization/templates/js/pltviz.js

rht · 2022-01-28T01:02:48Z

If the 3 TODOs are addressed, then this LGTM.

rht · 2022-01-28T08:20:08Z

mesa/visualization/templates/js/pltviz.js

@@ -0,0 +1,24 @@
+let PyPlotModule = function(canvas_width, canvas_height) {


This should be const.

And all the vars inside this function need to be declared with const/let. Default to const unless if it needs to be re-declared.

PyPlotModule must be const.

mesa/visualization/templates/js/pltviz.js

rht · 2022-01-30T07:49:24Z

The CI fails because matplotlib is not installed. TODO:

inside PyPlotVisualization.py, do a try import matplotlib. If this fail raises an error and say that the optional dependency matplotlib is missing

in setup.py, in extras_require, in dev, add matplotlib.

Not yet addressed.

vineetvermait · 2022-01-30T14:56:31Z

Resolved issues

setup.py

rht · 2022-01-30T16:02:11Z

inside PyPlotVisualization.py, do a try import matplotlib. If this fail raises an error and say that the optional dependency matplotlib is missing

Not yet addressed.

Also the new const comments not yet addressed.

mesa/visualization/modules/PyPlotVisualization.py

vineetvermait · 2022-02-01T09:59:00Z

Anything pending??

rht · 2022-02-01T14:15:49Z

There is one issue with the import matplotlib still not yet resolved
You need to squash your commits into 1 commit

rht · 2022-02-05T07:04:32Z

Here is an example UX in Pandas. I was trying to use the string[pyarrow] feature, which depends on an optional dependency of PyArrow. I got this error message:

ImportError: pyarrow>=1.0.0 is required for PyArrow backed StringArray.

We could use this concise error message instead of the long one I suggested.

rht · 2022-05-05T09:20:06Z

mesa/visualization/modules/PyPlotVisualization.py

+    def render(self, model: Model):
+        fig = self.img_func(model)
+        io_bytes = io.BytesIO()
+        fig.savefig(io_bytes, format="jpg")


The format should be "svg" instead.

Corvince · 2022-05-14T19:35:15Z

@vineetvermait are you still availabe for the remaining small points? If not would you mind me finishing the PR for you so we can get this merged?

rht · 2022-05-17T06:08:03Z

It has been 2 days. @Corvince you should just go for it.

rht · 2022-10-13T11:38:05Z

Bump.

Corvince · 2022-10-13T18:38:46Z

Thanks for the bump, I totally forgot about this!

rht · 2023-05-11T06:13:19Z

Closing, because I think the next-gent frontend for Mesa should be based on Streamlit/Panel/ipywidgets. This would result in simpler code (plus for maintainability), and that it is easier to be customized by the user. Followup discussion on #1622.

Adding Pyplot visualization

343db19

rht reviewed Jan 22, 2022

View reviewed changes

mesa/visualization/modules/PyPlotVisualization.py Outdated Show resolved Hide resolved

rht reviewed Jan 22, 2022

View reviewed changes

mesa/visualization/modules/PyPlotVisualization.py Outdated Show resolved Hide resolved

vineetvermait added 2 commits January 24, 2022 08:17

update for comments on PR

53c7b9f

update for comments on PR

ae1a615

rht reviewed Jan 24, 2022

View reviewed changes

mesa/visualization/modules/PyPlotVisualization.py Outdated Show resolved Hide resolved

vineetvermait and others added 3 commits January 24, 2022 11:08

update for comments on PR

3133608

Merge branch 'projectmesa:main' into main

8012a1e

update for comments on PR

926177b

vineetvermait added 2 commits January 25, 2022 12:46

update for comments on PR

9761d80

update for comments on PR

e811705

tpike3 requested changes Jan 25, 2022

View reviewed changes

docs/tutorials/adv_tutorial.ipynb Outdated Show resolved Hide resolved

docs/tutorials/adv_tutorial.ipynb Outdated Show resolved Hide resolved

docs/tutorials/adv_tutorial.rst Show resolved Hide resolved

vineetvermait added 4 commits January 26, 2022 11:54

update for comments on PR

9d4228f

update for comments on PR

e0bcd66

update for comments on PR

03b3ba2

update for comments on PR

788e1a0

vineetvermait requested a review from tpike3 January 27, 2022 06:19

tpike3 reviewed Jan 27, 2022

View reviewed changes

rht reviewed Jan 28, 2022

View reviewed changes

mesa/visualization/templates/js/pltviz.js Outdated Show resolved Hide resolved

update for comments on PR

4510943

vineetvermait requested a review from tpike3 January 28, 2022 04:45

rht reviewed Jan 28, 2022

View reviewed changes

update for comments on PR

2185d6b

rht reviewed Jan 30, 2022

View reviewed changes

mesa/visualization/templates/js/pltviz.js Outdated Show resolved Hide resolved

rht reviewed Jan 30, 2022

View reviewed changes

mesa/visualization/templates/js/pltviz.js Outdated Show resolved Hide resolved

update for comments on PR

1027344

rht reviewed Jan 30, 2022

View reviewed changes

setup.py Outdated Show resolved Hide resolved

update for comments on PR

c9e2694

rht reviewed Jan 31, 2022

View reviewed changes

mesa/visualization/modules/PyPlotVisualization.py Show resolved Hide resolved

wang-boyu mentioned this pull request Apr 1, 2022

How to adapt tick labels for horizontal axis in ChartModule? #1537

Open

rht reviewed May 5, 2022

View reviewed changes

rht closed this May 11, 2023

		@@ -0,0 +1,24 @@
		let PyPlotModule = function(canvas_width, canvas_height) {

Uh oh!

Adding Pyplot visualization #1139

Adding Pyplot visualization #1139

Uh oh!

Conversation

vineetvermait commented Jan 21, 2022

Uh oh!

EwoutH commented Jan 22, 2022

Uh oh!

Uh oh!

Uh oh!

vineetvermait commented Jan 24, 2022

Uh oh!

Uh oh!

codecov bot commented Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tpike3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vineetvermait commented Jan 27, 2022

Uh oh!

tpike3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rht commented Jan 28, 2022

Uh oh!

Uh oh!

rht commented Jan 28, 2022

Uh oh!

rht Jan 28, 2022

Choose a reason for hiding this comment

Uh oh!

rht Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rht Jan 30, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rht commented Jan 30, 2022

Uh oh!

vineetvermait commented Jan 30, 2022

Uh oh!

Uh oh!

rht commented Jan 30, 2022

Uh oh!

Uh oh!

vineetvermait commented Feb 1, 2022

Uh oh!

rht commented Feb 1, 2022

Uh oh!

rht commented Feb 5, 2022

Uh oh!

rht May 5, 2022

Choose a reason for hiding this comment

Uh oh!

Corvince commented May 14, 2022

Uh oh!

rht commented May 17, 2022

Uh oh!

rht commented Oct 13, 2022

Uh oh!

Corvince commented Oct 13, 2022

Uh oh!

rht commented May 11, 2023

Uh oh!

Uh oh!

codecov bot commented Jan 24, 2022 •

edited

Loading

tpike3 left a comment •

edited

Loading

rht Jan 28, 2022 •

edited

Loading