-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples #74
Update examples #74
Conversation
wang-boyu
commented
Jun 9, 2022
- update examples folder structure to be consistent with Mesa
- add test case for the examples in the same way as Mesa
- add a geo_schelling_points example
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
===========================================
+ Coverage 75.20% 85.67% +10.46%
===========================================
Files 5 5
Lines 363 363
Branches 57 57
===========================================
+ Hits 273 311 +38
+ Misses 69 37 -32
+ Partials 21 15 -6
Continue to review full report at Codecov.
|
I am actually in favor of a flatter file structure hierarchy, instead of example_model/example_model/model.py. There are not that many files anyway. See also: projectmesa/mesa#1269. We can bring this up in the meeting this month. |
Yup it's probably a matter of personal preferences. No matter what it is, it would be better to be consistent, and updated in the document here. We can discuss this later. |
Hash examples:
They seem to do it like how MATLAB does for its functions: 1 file per function. |
83e2673
to
69e26bc
Compare
I've updated the |
LGTM |