Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #74

Merged
merged 3 commits into from
Jun 20, 2022
Merged

Update examples #74

merged 3 commits into from
Jun 20, 2022

Conversation

wang-boyu
Copy link
Member

  • update examples folder structure to be consistent with Mesa
  • add test case for the examples in the same way as Mesa
  • add a geo_schelling_points example

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #74 (0b23818) into master (419f395) will increase coverage by 10.46%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #74       +/-   ##
===========================================
+ Coverage   75.20%   85.67%   +10.46%     
===========================================
  Files           5        5               
  Lines         363      363               
  Branches       57       57               
===========================================
+ Hits          273      311       +38     
+ Misses         69       37       -32     
+ Partials       21       15        -6     
Impacted Files Coverage Δ
mesa_geo/geoagent.py 78.16% <0.00%> (+5.74%) ⬆️
mesa_geo/geospace.py 88.26% <0.00%> (+14.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419f395...0b23818. Read the comment docs.

@rht
Copy link
Contributor

rht commented Jun 9, 2022

I am actually in favor of a flatter file structure hierarchy, instead of example_model/example_model/model.py. There are not that many files anyway. See also: projectmesa/mesa#1269. We can bring this up in the meeting this month.

@wang-boyu
Copy link
Member Author

Yup it's probably a matter of personal preferences. No matter what it is, it would be better to be consistent, and updated in the document here. We can discuss this later.

@rht
Copy link
Contributor

rht commented Jun 9, 2022

Hash examples:

They seem to do it like how MATLAB does for its functions: 1 file per function.

@wang-boyu wang-boyu force-pushed the examples branch 2 times, most recently from 83e2673 to 69e26bc Compare June 20, 2022 04:17
@wang-boyu
Copy link
Member Author

I've updated the geo_sir and geo_schelling examples to the flat folder structure, while keeping the geo_schelling_points folder structure.

@rht
Copy link
Contributor

rht commented Jun 20, 2022

LGTM

@rht rht merged commit b3f9e8b into projectmesa:master Jun 20, 2022
@wang-boyu wang-boyu deleted the examples branch June 20, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants