Fix 3 data path imports in gis models #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use relative imports in all models. This way models can be ran from different locations, which will help with testing them.
Co-Authored-By: rht <rhtbot@protonmail.com>
- Rename workflow - Run on each push (which allows developing on test branches in this repo) - Run only on changes to the example models, the test script or the CI config - Allow multiple commits after each other (to allow continuous trial and error
Fix the data path import errors in the geo_schelling, geo_schelling_points and geo_sir models.
EwoutH
force-pushed
the
fix_gis_data_paths
branch
from
0c587f6 to
3060079
Compare
|
Somehow I fucked up this branch, opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the data path import errors in the geo_schelling, geo_schelling_points and geo_sir models.
The problem was that many models are called from different place, and might be imported or not. The
os.path.dirname(os.path.abspath(__file__))part gives the absolute path of the current file and then the directory it's in. From there we can robustly move to the location where the data is located, no matter if we're running locally or not.Part of #172.