Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [issue #168] virus_on_network not updating #169

Closed
wants to merge 1 commit into from

Conversation

DrEntropy
Copy link

As stated in #168 virus_on_network visualization does not update as the model advances. The issue is that SolaraViz watches model._step which doesn't advance in this model because the model doesn't use a scheduler. This is fixed by calling self._advance_time() in model:step(). This is a one line change.

@DrEntropy DrEntropy changed the title Fix [#168](https://github.com/projectmesa/mesa-examples/issues/168) Fix [issue #168] virus_on_network not updating Aug 21, 2024
@EwoutH
Copy link
Member

EwoutH commented Aug 21, 2024

Thanks for the PR. I’m holding of with this PR until we have a bit more clarity on projectmesa/mesa#2223 / projectmesa/mesa#2227.

If it isn’t resolved next week, we’re either need to revert #161 or do this change for all models.

I hope it doesn’t come to that. Feel free to join any of the discussions.

@EwoutH
Copy link
Member

EwoutH commented Aug 22, 2024

Thanks for the PR, we've reverted #161 (done in #170), so we're back to the schedulers right now, until we have our conceptual view of time fully sorted out.

Thanks anyways!

@EwoutH EwoutH closed this Aug 22, 2024
@DrEntropy DrEntropy deleted the fix-virus-model branch August 22, 2024 13:54
@DrEntropy DrEntropy restored the fix-virus-model branch August 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants