Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NetBeans 8.x compile-on-save issue. #1775

Merged
merged 3 commits into from
Aug 27, 2018
Merged

Fix NetBeans 8.x compile-on-save issue. #1775

merged 3 commits into from
Aug 27, 2018

Conversation

charphi
Copy link
Contributor

@charphi charphi commented Jul 11, 2018

Fix #1577

@charphi charphi mentioned this pull request Jul 11, 2018
Closed
@md-5
Copy link
Contributor

md-5 commented Jul 11, 2018

Cool!

Going to bed now, but I develop with NetBeans 8.1 and am trying to migrate to NetBeans 9, so I will test both of these platforms tomorrow.

Cheers

@md-5
Copy link
Contributor

md-5 commented Jul 11, 2018

Works in NetBeans 8.1 (JDK8) and NetBean 9 (JDK10).
👍

@charphi
Copy link
Contributor Author

charphi commented Jul 12, 2018

Great. Thanks!

@rspilker
Copy link
Collaborator

Can you please add your name to the AUTHORS file at the appropriate location? Then we are legally covered.

@md-5
Copy link
Contributor

md-5 commented Aug 22, 2018

Don't like nagging, but do you think we could please get this for next release @rspilker ?

@rspilker rspilker merged commit 3ffac66 into projectlombok:master Aug 27, 2018
@rspilker
Copy link
Collaborator

Done.

@md-5
Copy link
Contributor

md-5 commented Aug 27, 2018

Thanks!

@charphi
Copy link
Contributor Author

charphi commented Aug 28, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charphi @md-5 @rspilker