-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request [internal]: Universally fix up the Javac.storeEnd table #2691
Closed
rzwitserloot opened this issue
Jan 2, 2021
· 2 comments
· Fixed by #2726, ImSejin/lezhin-comics-downloader#22, nelkinda/uropia-tax-calculator-assignment#6, TiagoMSSantos/MobileRT#196 or codingsolutions-ninja/solar-edge-api-client#9
Closed
Feature request [internal]: Universally fix up the Javac.storeEnd table #2691
rzwitserloot opened this issue
Jan 2, 2021
· 2 comments
· Fixed by #2726, ImSejin/lezhin-comics-downloader#22, nelkinda/uropia-tax-calculator-assignment#6, TiagoMSSantos/MobileRT#196 or codingsolutions-ninja/solar-edge-api-client#9
Comments
If you haven't started with this yet, I would work on this one. Most likely this will be a pretty huge refctoring as every handler that generates something new has to be updated. |
You got the green light from me, I haven't started on this at all, nor has @rspilker |
Rawi01
added a commit
to Rawi01/lombok
that referenced
this issue
Jan 27, 2021
rspilker
pushed a commit
that referenced
this issue
Jan 28, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lombok appears to not always properly add generated nodes to Javac's
storeEnd
table. This doesn't do much (positions of generated nodes are perpetually in a state of limbo, as so many tools make assumptions that do not hold, such as that no 2 exclusive nodes can share a start position, or that nodes have non-zero length), but it should help a little bit sometimes. It is hard to know what the impact is (it'll impact compiler plugins of all stripes, most likely) for example:I'm pretty sure it's worth doing this update and then deal with issues as they are raised if doing this causes other tooling to do bizarre things. Most likely it causes other tools to shift from exceptions to undesired reporting on generated code, but we can then start filing requests with those libraries to add facilities for ignoring generated code, and add documentation to the site to explain how to set it up (if we can't convince the project maintainers of things like errorprone to recognize lombok itself and bake into their code that lombok means: generated, so, skip).
The text was updated successfully, but these errors were encountered: