Update to latest ka9q-radio commit #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm running ca8c687479b8aa965e749ec2a365ce41ba50f96b on my two stations (both native installs, 1.8.1-beta7), and it's working well so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent ka9q-radio bug causes diagnostic messages to be printed into pcmrecord's output, corrupting the signal output: ka9q/ka9q-radio#113
This situation occurs if multicast is not enabled on the loopback interface. It is off by default on Linux, but radiod enables it as long as it has the
cap_net_admincapability. ka9q-radio gives radiod this capability in its installer (https://github.com/ka9q/ka9q-radio/blob/ca8c687479b8aa965e749ec2a365ce41ba50f96b/Makefile.linux#L86) but a containerized ka9q-radio might not have the capability.The bug was introduced in ka9q/ka9q-radio@231d020 and fixed in ka9q/ka9q-radio@0bb4d29.
I think we should update to the latest ka9q-radio to pick up the fix.
This will also be a good commit to recommend in the wiki, since it also fixes undefined behaviour in radiod's startup routine: ka9q/ka9q-radio#111. But ka9q-radio's makefile no longer builds pcmcat by default, so we shouldn't recommend this in the wiki until 1.8.1 is out.