v1.8.1-beta2 - KA9Q Channel Filter, RS41/DFM Estimator BW Tweaks #962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some possible performance impacting changes in this one.
In response to an issue observed by @argilo where a DFM and RS41 are regularly seen only 10 kHz apart, I've made the following changes:
We should look into the validity of the current estimator ranges for other sonde types, and whether the mask estimator adds any performance improvement.
Some testing data of mask estimator vs no mask estimator:
RS41 - No Mask Estimator
RS41 - 4800 Hz Mask Estimator
(Approx 0.5 dB improvement)
DFM - No Mask Estimator
DFM - 5080 Hz Mask Estimator
(Not really any performance gain in this case, maybe a slight degradation)