Add a frequency column to the Sonde List and add a visibility setting of each column of it. #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! I'm going to make a few tweaks once it's in the testing branch, but otherwise it's a good addition! |
|
@darksidelemm Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hoped to add a frequency column to the Sonde List same as #729.
So I made it based on a suggestion of the following comment.
#729 (comment)
I added a settings icon of Sonde List to the same position as "main" page.
I have one issue of a icon position of "return to main" and "SkewT".
I think that it is better that a icon position of "return to main" and "go to history" is same as current version.
So I swapped them.
Please check!