-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update to Bevy 0.15 #17
Conversation
3604e5b
to
077eaa0
Compare
077eaa0
to
1a453a7
Compare
Thanks for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for the renet release to merge.
#[cfg(feature = "renet_transport")] | ||
let client_id = Some(transport.client_id().to_replicon()); | ||
#[cfg(not(feature = "renet_transport"))] | ||
#[cfg(feature = "renet_netcode")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think we need to do the same for the steam feature 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matoous could you also take a look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look. Seems like renet_steam
heavily relies on steamworks::Client
so it might need further changes. Might need to read some more about how this works 👀
I see that docs are failing 🙈 missed that part during development, will fix it during the week. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 97.84% 97.77% -0.08%
==========================================
Files 3 3
Lines 93 90 -3
==========================================
- Hits 91 88 -3
Misses 2 2 ☔ View full report in Codecov by Sentry. |
I think this PR missed updating all of the examples. That said, renet is updated now. |
Great, starting to work on this PR. |
Updated to the latest renet and addressed the steam integraiton. |
Still waiting for latest tagged release of renet.
Changes
transport
in renet was moved undernetcode
in latest version ofbevy_renet
, ref.: lucaspoffo/renet@042ede9#diff-f615dba06c307102205077c64d4ac874279d20c882f5319a57874951e4c1af3aR15. Andserde
is no longer required bybevy_renet
. This adjusts for both. Alsorenet
ClientId
is now just type alias foru64
so that part can be simplified.This removes
renet_serde
, andrenet_transport
in favor ofrenet_netcode
.