Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to Bevy 0.15 #17

Merged
merged 7 commits into from
Dec 25, 2024

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Dec 13, 2024

Still waiting for latest tagged release of renet.

Changes

transport in renet was moved under netcode in latest version of bevy_renet, ref.: lucaspoffo/renet@042ede9#diff-f615dba06c307102205077c64d4ac874279d20c882f5319a57874951e4c1af3aR15. And serde is no longer required by bevy_renet. This adjusts for both. Also renet ClientId is now just type alias for u64 so that part can be simplified.

This removes renet_serde, and renet_transport in favor of renet_netcode.

@matoous matoous force-pushed the md/bevy-0.15 branch 3 times, most recently from 3604e5b to 077eaa0 Compare December 14, 2024 12:36
@matoous matoous changed the title [WIP] chore(deps): update to Bevy 0.15 chore(deps): update to Bevy 0.15 Dec 14, 2024
@matoous matoous marked this pull request as ready for review December 14, 2024 12:45
@Shatur
Copy link
Contributor

Shatur commented Dec 14, 2024

Thanks for the help!

Copy link
Contributor

@Shatur Shatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the renet release to merge.

#[cfg(feature = "renet_transport")]
let client_id = Some(transport.client_id().to_replicon());
#[cfg(not(feature = "renet_transport"))]
#[cfg(feature = "renet_netcode")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think we need to do the same for the steam feature 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matoous could you also take a look at this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look. Seems like renet_steam heavily relies on steamworks::Client so it might need further changes. Might need to read some more about how this works 👀

@matoous
Copy link
Contributor Author

matoous commented Dec 14, 2024

I see that docs are failing 🙈 missed that part during development, will fix it during the week.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (8f9171f) to head (8013ceb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   97.84%   97.77%   -0.08%     
==========================================
  Files           3        3              
  Lines          93       90       -3     
==========================================
- Hits           91       88       -3     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Luminoth
Copy link
Contributor

I think this PR missed updating all of the examples. That said, renet is updated now.

@Shatur
Copy link
Contributor

Shatur commented Dec 24, 2024

Great, starting to work on this PR.

@Shatur
Copy link
Contributor

Shatur commented Dec 24, 2024

Updated to the latest renet and addressed the steam integraiton.
Need to update examples, I will back to it in a few hours. If anyone wants to beat me to it, you are welcome 😅

@Shatur Shatur enabled auto-merge (squash) December 25, 2024 01:20
@Shatur Shatur merged commit 474df96 into projectharmonia:master Dec 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants