Remove pyxdg dependency #727
Conversation
There was a problem hiding this comment.
It looks like GLib.get_user_data_dir will also return XDG_DATA_HOME (which according to XDG specs defaults to ~/.local/share just like we did), so I think this PR will produce the same behavior as before, but with one less dependency (we already depend on glib), so looks good to me.
I'm approving this based on my code review, it should probably be tested by someone else (or me later) before actually merging.
|
Automatically generated build artifacts for commit b3f293e (note: these links will expire after some time):
To test this PR, download and unzip the flatpak application above and then install with: |
|
Small update to fix flake8 check. |
|
Automatically generated build artifacts for commit d7f0f74 (note: these links will expire after some time):
To test this PR, download and unzip the flatpak application above and then install with: |
|
@aquaherd, I believe you've been using "rebase and merge" for merging some recent pull requests, right? I think we should prefer regular merging (or for single-commit PRs squash-merging), since then the commit history retains a reference to the pullrequest that a commit came from. See also #585 for some (draft - we should finalize that) development guidelines. No worries for now, just something to keep in mind for the future. |
|
Ok will do. |
No description provided.