Add type hints to fluent.syntax & fluent.runtime #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
force-pushed
the
hints
branch
5 times, most recently
from
b2f8bb4 to
c498d15
Compare
|
Are you planning on bumping to 0.19 after this? |
|
Yes. |
eviljeff
reviewed
Mar 9, 2023
| elif is_number(val2): | ||
| return match(val2, val1, env) | ||
|
|
||
| return val1 == val2 | ||
| return cast(bool, val1 == val2) |
There was a problem hiding this comment.
out of interest, why do we have to cast an equality expression to bool? Isn't an equality expression implicitly a boolean?
There was a problem hiding this comment.
It's because the inputs are Any, and that at least technically allows for an __eq__(self, other) overload that returns something other than a bool.
| maximumFractionDigits = attr.ib(default=None) | ||
| minimumSignificantDigits = attr.ib(default=None) | ||
| maximumSignificantDigits = attr.ib(default=None) | ||
| style: Literal['decimal', 'currency', 'percent'] = attr.ib( |
There was a problem hiding this comment.
should we use the FORMAT_STYLE_DECIMAL etc constants here instead?
There was a problem hiding this comment.
I don't think that's possible with Literal[], or at least I'm not aware of a way of an alternative type expression that would resolve to this.
Co-authored-by: Andrew Williamson <awilliamson@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
The work here is split into commits that may be easier to review separately. The internal hints for the runtime resolver and compiler are pretty weak, as the base implementation is making explicit use of the language being fundamentally untyped.
The bugs that are fixed are all various sorts of corner cases that the code didn't account for previously; the errors tend to follow similar cases in fluent.js.
While adding the types I used both mypy and pylance; the added CI tests only apply
mypy --strictas the strict-mode pylance checks don't all pass (mostly due to usingUnknownvalues in places that acceptAny).