Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.7, 3.5 support, add 3.6-3.9 for fluent.runtime, fluent.pygments #163

Merged
merged 6 commits into from
Mar 8, 2021

Conversation

Pike
Copy link
Contributor

@Pike Pike commented Feb 24, 2021

Much like #161 , same same but different.

I thought I'd need fluent.syntax to be released for this, but that can decide on its own if it needs six/py2 compat or not. Once it releases, we just need to expand the compat and testing constraints here.

@Pike
Copy link
Contributor Author

Pike commented Feb 24, 2021

As you can tell, I lied just a little bit, I guess we'll be fine requiring six now, and then bumping the dependency on syntax and dropping six later, aka post-syntax-release.

@zbraniecki r?

@Pike Pike requested a review from zbraniecki March 2, 2021 21:44
@Pike Pike added fluent.pygments fluent.runtime Issues related to the fluent.runtime module. labels Mar 2, 2021
Copy link
Collaborator

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pike Pike merged commit ae416d0 into projectfluent:master Mar 8, 2021
@Pike Pike deleted the more-drops-python2 branch March 8, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent.pygments fluent.runtime Issues related to the fluent.runtime module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants