Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change line endings in comments to line_end #219

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Nov 16, 2018

The /.*/ regex doesn't match any of the line endings recognized by the JS RegExp engine, i.e. \n, \r, \u2028, \u2029. These are different from the line endings supported by the rest of the Fluent Syntax. This change unifies the line endings in all grammar productions.

The /.*/ regex doesn't match any of the line endings recognized by the
JS RegExp engine, i.e. \n, \r, \u2028, \u2029. These are different from
the line endings supported by the rest of the Fluent Syntax. This change
unifies the line endings in all grammar productions.
@stasm stasm requested a review from Pike November 16, 2018 13:42
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do the same for comments and junk. Not sure if they should share a rest_of_line production, but they should implement the same solution for the problem.

Not opinionated on which of the two impls to use.

@stasm
Copy link
Contributor Author

stasm commented Nov 19, 2018

We should do the same for comments and junk. Not sure if they should share a rest_of_line production, but they should implement the same solution for the problem.

I think they are different and they shouldn't share the same solution. Line endings in Comments are normalized to LF. Line endings in Junk are unchanged, as per #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants