Add parameterized Attributes #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
attr-params
branch
2 times, most recently
from
881d8fc to
0bbd3dd
Compare
|
|
Pike
approved these changes
Nov 14, 2018
| return always(new Type(ref, name)); | ||
| } | ||
| return never(`Invalid ref type: ${ref.type}.`); | ||
| }; |
There was a problem hiding this comment.
I think this part is not needed with the reduced changes after the rebase? Attributes are always on messages or terms still.
There was a problem hiding this comment.
You're right, but I'd like to keep this here for the sake of completeness. I think it complements the validation of CallExpression. Let's keep it for now and I'll see if I can remove it in a follow-up.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #189. Add syntax to allow expressions of the form
-term.attr(arg: "value"), e.g.: