Dedent multiline text to preserve content indentation #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pike This is based on your branch from #162 (comment). Here's a summary of differences:
|
Pike
approved these changes
Nov 6, 2018
syntax/abstract.mjs
Outdated
| @@ -154,18 +159,36 @@ function attach_comments(acc, cur) { | |||
| } | |||
| } | |||
|
|
|||
| const LEADING_BLANK = /^[ \n\r]*/; | |||
| const TRAILING_BLANK = /[ \n\r]*$/; | |||
| // Remove the largest common indentation from a list of PatternElements. | |||
There was a problem hiding this comment.
Extend this comment to make it expressive that all literal strings are indents, thanks to grammar.mjs separating those out?
| function join_adjacent(...types) { | ||
| return function(acc, cur) { | ||
| let prev = acc[acc.length - 1]; | ||
| for (let Type of types) { | ||
| if (prev instanceof Type && cur instanceof Type) { | ||
| join_of_type(Type, prev, cur); | ||
| // Replace prev with a new node of the same type whose value is | ||
| // the sum of prev and cur, and discard cur. |
There was a problem hiding this comment.
Do you think it's needed given that the comment starts with Replace...?
There was a problem hiding this comment.
I could go without the , and discard ... altogether, too.
Pike
approved these changes
Nov 6, 2018
| function join_adjacent(...types) { | ||
| return function(acc, cur) { | ||
| let prev = acc[acc.length - 1]; | ||
| for (let Type of types) { | ||
| if (prev instanceof Type && cur instanceof Type) { | ||
| join_of_type(Type, prev, cur); | ||
| // Replace prev with a new node of the same type whose value is | ||
| // the sum of prev and cur, and discard cur. |
There was a problem hiding this comment.
I could go without the , and discard ... altogether, too.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #162.