Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store the term sigil in the identifier name #183

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Don't store the term sigil in the identifier name #183

merged 1 commit into from
Oct 17, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Oct 16, 2018

Fix #142.

@stasm stasm requested a review from Pike October 16, 2018 08:52
Pike
Pike suggested changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but the lack of test coverage for VariableReference bothers me.

Can you add a test for that?

@stasm stasm force-pushed the consistent-sigils branch from 8f14884 to 780cea1 Compare October 17, 2018 11:53
@stasm stasm requested a review from Pike October 17, 2018 11:54
@stasm stasm merged commit bac1271 into projectfluent:master Oct 17, 2018
@stasm stasm deleted the consistent-sigils branch October 17, 2018 17:01
zbraniecki pushed a commit to zbraniecki/fluent that referenced this pull request Oct 22, 2018
@stasm
Don't store the term sigil in the identifier name (projectfluent#183)
6e60296
@stasm stasm mentioned this pull request Nov 15, 2018
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pike Pike Pike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @Pike