Syntax 0.8, part 4: Add parameterized terms (macros) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2018
Closed
stasm
force-pushed
the
zeroeight-part4-macros
branch
from
2644733 to
4ec7412
Compare
stasm
force-pushed
the
zeroeight-part4-macros
branch
from
4ec7412 to
ecf3207
Compare
Pike
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
The resolver tests are good.
The tooling parser changes rub me backwards, in the sense that the code prior to this patch rubs me backwards, and now more. That doesn't make them wrong, but the changes like literal -> selector here made the code harder to understand for me. The not-msg-or-term-ref change to literal-or-var-ref, too. 'Cause at that point, I had no idea which kind of literal is left to handle. I filed #315 on that.
|
Thanks! I'll work on #315 tomorrow. I can see a lot of room for improvement, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement projectfluent/fluent@dc20d52, without parameterized attributes, which I'll do in a different PR.
Depends on #310.