Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluent-syntax] Calling clone() on a node should return a value with node's type, not BaseNode #589

Closed
eemeli opened this issue Apr 28, 2022 · 1 comment
Closed

[fluent-syntax] Calling clone() on a node should return a value with node's type, not BaseNode #589

eemeli opened this issue Apr 28, 2022 · 1 comment
Labels
fluent-syntax good first bug

Comments

@eemeli
Copy link
Member

eemeli commented Apr 28, 2022

The correct TS type here would be this:

fluent.js/fluent-syntax/src/ast.ts

Line 50 in a68c20e

clone(): BaseNode {

eemeli added a commit to eemeli/fluent.js that referenced this issue Apr 28, 2022
@eemeli
fix(fluent-syntax): Use correct TS type for clone() return (projectfl…
788e4df 
…uent#589)
@eemeli eemeli mentioned this issue Apr 28, 2022
Merged
@AleksandrSl
Copy link

The issue seems to be resolved, so it can be closed 😀

@eemeli eemeli closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fluent-syntax good first bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eemeli @AleksandrSl