Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a retry policy to retry for HTTP Error codes >= 500 and refactor #26

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Add a retry policy to retry for HTTP Error codes >= 500 and refactor #26

merged 2 commits into from
Nov 15, 2022

Conversation

jdk2588
Copy link
Contributor

@jdk2588 jdk2588 commented Nov 8, 2022 •
edited
Loading

code to use common funcs. In reference to https://github.com/projectdiscovery/nuclei-cloud/issues/123

Mzack9999
Mzack9999 requested changes Nov 8, 2022
View reviewed changes
@jdk2588 jdk2588 requested a review from Mzack9999 November 15, 2022 11:58
Mzack9999
Mzack9999 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - +1 variadic implementation!

@ehsandeep ehsandeep merged commit 821ced1 into master Nov 15, 2022
@ehsandeep ehsandeep deleted the http_error_code branch November 15, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdk2588 @ehsandeep @Mzack9999 @Ice3man543