Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching stuck-go routines causing deadline errors #381

Merged
merged 7 commits into from
Dec 8, 2024

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Dec 4, 2024

This PR patches singleflight routine to allow stuck go-routines to proceed with standard dialing.

Closes projectdiscovery/nuclei#5881

@Mzack9999 Mzack9999 self-assigned this Dec 4, 2024
@Mzack9999 Mzack9999 changed the title Patching singleflight Patching stuck-go routines causing deadline errors Dec 8, 2024
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 8, 2024
@Mzack9999 Mzack9999 requested a review from Ice3man543 December 8, 2024 13:32
@Mzack9999 Mzack9999 marked this pull request as ready for review December 8, 2024 13:32
@ehsandeep ehsandeep merged commit 3c45460 into main Dec 8, 2024
5 checks passed
@ehsandeep ehsandeep deleted the bugfix-investigate-slow branch December 8, 2024 22:47
@tarunKoyalwar tarunKoyalwar restored the bugfix-investigate-slow branch December 9, 2024 12:04
@tarunKoyalwar tarunKoyalwar deleted the bugfix-investigate-slow branch December 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
3 participants