add asn input #249
Merged
add asn input #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update mapcidr IpAddresses to IPAddressesStream for memory optimize - Add asn input support by integrating mapcidr/asn - Refactor the processInput function - Add test cases for processInput and InputStreamWorker to validate the change
ShubhamRasal
added
the
Status: In Progress
ShubhamRasal
added
Status: Review Needed
|
add |
jdk2588
approved these changes
Oct 18, 2022
- Use asnmap client for each query - If client is shared it is failing for more than one query - Use fmt.Sprintf to concatenate string
ShubhamRasal
added
the
Status: Review Needed
- Update runner.go to check if A record is nil then lookup for IP address. eg. `dnsx -silent -cname -asn`
ehsandeep
approved these changes
Oct 19, 2022
Mzack9999
approved these changes
Oct 19, 2022
- Change the asn struct variable name
- When there is no record for asn, it was printing asn{} in json output.
Update behaviour to remove asn totally if asn record is not found.
ehsandeep
approved these changes
Oct 19, 2022
ehsandeep
removed
Status: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPAddressestoIPAddressesStreamfor memory optimizeprocessInputfunctionprocessInputand InputStreamWorker to validate thechange