Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepcopy generation script #6791

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Nov 26, 2024

The script hack/generate-crd-deepcopy.sh was unintentionally rendered ineffective by #6117. This occurred because exec replaces the current shell process with the specified binary, preventing remaining lines of the script from running.

This update restores the deepcopy generation functionality and includes the results of make generate to address changes missed since the last successful run.

Fixes #6790

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
@tsaarni tsaarni requested a review from a team as a code owner November 26, 2024 06:28
@tsaarni tsaarni requested review from skriss and sunjayBhatia and removed request for a team November 26, 2024 06:28
@sunjayBhatia sunjayBhatia requested review from a team, wilsonwu and davinci26 and removed request for a team November 26, 2024 06:28
@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (d05f43a) to head (d9f6aec).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6791   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         133      133           
  Lines       20026    20026           
=======================================
  Hits        16232    16232           
  Misses       3500     3500           
  Partials      294      294           

@sunjayBhatia sunjayBhatia merged commit da03924 into projectcontour:main Dec 3, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The generation of zz_generated.deepcopy.go is broken
2 participants