Design: External Processing support #5866

izturn · 2023-10-19T03:39:51Z

Signed-off-by: Gang Liu gang.liu@daocloud.io

Design proposal to address #5123

Signed-off-by: gang.liu <gang.liu@daocloud.io>

github-actions · 2023-11-03T00:18:51Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2023-11-30T00:20:10Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

design/external-processing-design.md

izturn · 2023-12-13T02:38:15Z

Sorry, I am very busy this month, But this task will be my main focus next month

github-actions · 2023-12-29T00:16:37Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

clayton-gonsalves

left a few comments on the configuration approach

Signed-off-by: gang.liu <gang.liu@daocloud.io>

github-actions · 2024-04-20T00:19:32Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

izturn · 2024-04-28T06:43:45Z

ping @clayton-gonsalves

tsaarni · 2024-04-29T17:37:50Z

design/external-processing-design.md

+      externalProcessing:
+        disabled: false
+        processor:
+          extensionRef:
+            apiVersion: projectcontour.io/v1alpha1
+            name: extproc-extsvc3
+            namespace: extproc-test
+          failOpen: true
+          responseTimeout: 31s
+          processingMode:
+            requestBodyMode: NONE
+            requestHeaderMode: SKIP
+            requestTrailerMode: SKIP
+            responseBodyMode: NONE
+            responseHeaderMode: SEND
+            responseTrailerMode: SKIP


In my opinion, repeating the whole ExternalProcessing struct at route level is not optimal API - it gets too verbose and I think for other similar cases we have used different approach earlier.

What would you think about (re)using the approach that JWT verification implements, where we define one or more named processors at virtualhost level and then at route level refer to one processor by its name? In that case, one or more routes can refer to a processor without repeating the full set of parameters at each route.

I considered this approach, but did not adopt it for the following reasons:

The current design is based on the auth implementation, not the jwt.

From the Envoy configuration definition, the structure of jwt and ext_proc is very different. In jwt the external server(s) defined at the virtualhost level are only used as a temporary storage place for server(s) (and then referenced at the route level) and do not have a real effect. However, this is not the case with ext_proc. Therefore, if multiple server(s) are defined at the virtualhost level, then at each route level, the corresponding server(s) must be explicitly enabled or disabled, which increases the difficulty of configuration.

The jwt scheme is similar to the scheme we designed in the first version. In our actual use, we have found that while this is flexible, it is more difficult to understand and use.

Based on the above reasons and our internal practices, I personally believe that the current design is more reasonable.

In jwt the external server(s) defined at the virtualhost level are only used as a temporary storage place for server(s) (and then referenced at the route level) and do not have a real effect. However, this is not the case with ext_proc. Therefore, if multiple server(s) are defined at the virtualhost level, then at each route level, the corresponding server(s) must be explicitly enabled or disabled, which increases the difficulty of configuration.

I might be missing something, since I do not see the difference:

The JWT API defines providers as temporary storage for server info as you say, but it also allows setting one as the default provider which is then automatically applied to all routes. Routes can still opt-out by disabling JWT verification explicitly, or require a specific (non-default) provider.

On the other hand, if I understood the current proposal correctly, for (non-default) route level external processor, the current API requires user to re-define the external processor server parameters again on each route, even in the case when two separate routes would share single processor. Wouldn't "distributing" the configuration like that lead into duplication of configuration?

The current design prioritizes flexibility but results in excessive verbosity. It might be beneficial to introduce a vhost-level extproc setting to alleviate redundancy, especially within the same vhost/proxy.

The configuration on the config seems a bit in between to me where we provide flexibilty but in a sense limited. Historically, we've maintained global defaults in the configuration, managed by admins or cluster admins. IMO, service-specific settings within it feels somewhat out of place

github-actions · 2024-05-27T00:21:31Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-06-14T00:21:10Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-06-30T00:24:01Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-07-19T00:43:45Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-08-03T00:21:49Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-08-18T00:24:46Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

github-actions · 2024-09-09T00:25:21Z

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 14d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
Mark this PR as fresh by commenting or pushing a commit
Close this PR
Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

izturn added 3 commits October 17, 2023 18:03

design for ext_proc

5f79638

Signed-off-by: gang.liu <gang.liu@daocloud.io>

fix typo

dfd7d4a

Signed-off-by: gang.liu <gang.liu@daocloud.io>

Merge remote-tracking branch 'upstream/main' into feat/extproc-design

845d1b5

izturn requested a review from a team as a code owner October 19, 2023 03:39

izturn requested review from stevesloka and sunjayBhatia and removed request for a team October 19, 2023 03:39

izturn self-assigned this Oct 19, 2023

izturn mentioned this pull request Oct 25, 2023

[Feature Discussion] The ways to extend/custom functionalities for Envoy: WASM vs. Lua vs. External Processing vs. GO filter #5123

Closed

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023

izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 3, 2023

sunjayBhatia requested review from tsaarni, skriss and clayton-gonsalves November 15, 2023 19:03

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 30, 2023

tsaarni reviewed Dec 1, 2023

View reviewed changes

design/external-processing-design.md Outdated Show resolved Hide resolved

design/external-processing-design.md Outdated Show resolved Hide resolved

design/external-processing-design.md Outdated Show resolved Hide resolved

github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2023

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2023

izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2024

izturn added 2 commits January 9, 2024 17:39

Merge branch 'main' into feat/extproc-design

501c067

Merge remote-tracking branch 'upstream/main' into feat/extproc-design

55e0918

clayton-gonsalves mentioned this pull request Mar 27, 2024

Implementation: External Processing support #5867

Open

clayton-gonsalves suggested changes Mar 27, 2024

View reviewed changes

refactor

3f09188

Signed-off-by: gang.liu <gang.liu@daocloud.io>

izturn requested a review from clayton-gonsalves April 2, 2024 10:41

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 20, 2024

tsaarni reviewed Apr 29, 2024

View reviewed changes

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2024

izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2024

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 14, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2024

izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2024

izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2024

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2024

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2024

izturn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2024

github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Design: External Processing support #5866

Design: External Processing support #5866

izturn commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Nov 3, 2023

github-actions bot commented Nov 30, 2023

izturn commented Dec 13, 2023

github-actions bot commented Dec 29, 2023

clayton-gonsalves left a comment

github-actions bot commented Apr 20, 2024

izturn commented Apr 28, 2024

tsaarni Apr 29, 2024

izturn May 8, 2024

tsaarni May 8, 2024

clayton-gonsalves May 8, 2024

github-actions bot commented May 27, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 30, 2024

github-actions bot commented Jul 19, 2024

github-actions bot commented Aug 3, 2024

github-actions bot commented Aug 18, 2024

github-actions bot commented Sep 9, 2024

Design: External Processing support #5866

Are you sure you want to change the base?

Design: External Processing support #5866

Conversation

izturn commented Oct 19, 2023 • edited Loading

github-actions bot commented Nov 3, 2023

github-actions bot commented Nov 30, 2023

izturn commented Dec 13, 2023

github-actions bot commented Dec 29, 2023

clayton-gonsalves left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 20, 2024

izturn commented Apr 28, 2024

tsaarni Apr 29, 2024

Choose a reason for hiding this comment

izturn May 8, 2024

Choose a reason for hiding this comment

tsaarni May 8, 2024

Choose a reason for hiding this comment

clayton-gonsalves May 8, 2024

Choose a reason for hiding this comment

github-actions bot commented May 27, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 30, 2024

github-actions bot commented Jul 19, 2024

github-actions bot commented Aug 3, 2024

github-actions bot commented Aug 18, 2024

github-actions bot commented Sep 9, 2024

izturn commented Oct 19, 2023 •

edited

Loading