Add deployment example #4126

stevesloka · 2021-10-20T20:37:59Z

Adds an example for running Envoy as a deployment vs a daemonset
Updates the e2e tests to read an env var to determine if the deployment version should be run
Enables running e2e tests for Envoy deployment on each PR build (😱)

codecov · 2021-10-20T20:45:55Z

Codecov Report

Merging #4126 (13c97a7) into main (4f025fe) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4126      +/-   ##
==========================================
- Coverage   77.78%   77.77%   -0.02%     
==========================================
  Files         112      112              
  Lines       10005    10005              
==========================================
- Hits         7782     7781       -1     
- Misses       2040     2041       +1     
  Partials      183      183

Impacted Files	Coverage Δ
internal/sorter/sorter.go	`98.18% <0.00%> (-0.61%)`	⬇️

stevesloka · 2021-10-20T20:54:18Z

I thought about just having the deployment version run hourly or something to pick up issues vs running on each PR. That might reduce the churn time for each iteration.

github-actions · 2021-11-04T00:11:06Z

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

skriss

👍 to having this as an example. It'd also be good to update examples/contour/README.md, as well as some stuff in the docs about deployment options (e.g. https://projectcontour.io/docs/v1.19.1/deploy-options/, maybe some other pages too)

.github/workflows/prbuild.yaml

examples/contour/03-envoy-deployment.yaml

youngnick

LGTM, I agree with @skriss about the risk of burning all our Actions time if we have a few PRs though.

.github/workflows/prbuild.yaml

examples/contour/03-envoy-deployment.yaml

stevesloka · 2021-11-19T17:40:33Z

@skriss @sunjayBhatia I refactored this a bit to add some "deployment" tests. I'd like to write up some docs, but can follow that up with a new PR.

test/e2e/httpproxy/httpproxy_test.go

.github/workflows/prbuild.yaml

test/e2e/deployment.go

test/e2e/deployment/deployment_test.go

sunjayBhatia · 2021-11-30T16:44:58Z

ah @stevesloka just merged #4170 and realized there will be merge conflicts now, my apologies

stevesloka · 2021-12-01T16:55:00Z

No worries @sunjayBhatia, all rebased!

github-actions · 2021-12-16T00:11:37Z

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

skriss

This looks pretty good, one small merge conflict to resolve. I do think de-duping the tests would be good, but maybe we can do that in a follow-up for the sake of getting this in.

test/e2e/framework.go

skriss · 2022-01-04T17:13:39Z

test/e2e/deployment/path_condition_match_test.go

+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func testPathConditionMatch(namespace string) {


If we wanted to get this in as-is, I'd be willing to take the follow-up to do some de-duplication here.

Signed-off-by: Steve Sloka <slokas@vmware.com>

stevesloka · 2022-01-07T20:01:57Z

If we wanted to get this in as-is, I'd be willing to take the follow-up to do some de-duplication here.

@skriss @sunjayBhatia I think that's a good plan, merge this in and we can refactor everything around maybe. What do you think?

Signed-off-by: Steve Sloka <slokas@vmware.com>

skriss · 2022-01-07T20:56:15Z

If we wanted to get this in as-is, I'd be willing to take the follow-up to do some de-duplication here.

@skriss @sunjayBhatia I think that's a good plan, merge this in and we can refactor everything around maybe. What do you think?

It works for me. I was thinking that maybe another path here would be to run the full suite of E2E's against a Deployment as part of the daily run, so we could make a decision on that and then make some subsequent revisions here.

stevesloka · 2022-01-10T19:45:26Z

I'm inclined to just merge this, then I'll add it to the daily build to help validate. Just want to check in with you @sunjayBhatia if that makes sense.

sunjayBhatia · 2022-01-10T21:03:10Z

I'm inclined to just merge this, then I'll add it to the daily build to help validate. Just want to check in with you @sunjayBhatia if that makes sense.

sounds good to me 👍🏽 good to get changes in and then we can refactor the CI as needed

stevesloka added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Oct 20, 2021

stevesloka requested a review from a team as a code owner October 20, 2021 20:38

stevesloka requested review from skriss and sunjayBhatia and removed request for a team October 20, 2021 20:38

stevesloka force-pushed the addDeploymentExample branch from e449db6 to 6f112c8 Compare October 20, 2021 20:42

stevesloka added release-note/minor A minor change that needs about a paragraph of explanation in the release notes. and removed release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. labels Oct 20, 2021

stevesloka mentioned this pull request Oct 20, 2021

move Envoy from daemonset to deployment #4063

Closed

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2021

skriss reviewed Nov 4, 2021

View reviewed changes

.github/workflows/prbuild.yaml Outdated Show resolved Hide resolved

examples/contour/03-envoy-deployment.yaml Outdated Show resolved Hide resolved

youngnick approved these changes Nov 4, 2021

View reviewed changes

.github/workflows/prbuild.yaml Outdated Show resolved Hide resolved

sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2021

r0bj reviewed Nov 10, 2021

View reviewed changes

examples/contour/03-envoy-deployment.yaml Outdated Show resolved Hide resolved

stevesloka force-pushed the addDeploymentExample branch 3 times, most recently from 0139066 to 3dfad38 Compare November 18, 2021 03:06

stevesloka requested a review from skriss November 19, 2021 17:39

sunjayBhatia reviewed Nov 22, 2021

View reviewed changes

test/e2e/httpproxy/httpproxy_test.go Outdated Show resolved Hide resolved

sunjayBhatia reviewed Nov 22, 2021

View reviewed changes

.github/workflows/prbuild.yaml Outdated Show resolved Hide resolved

sunjayBhatia reviewed Nov 23, 2021

View reviewed changes

test/e2e/deployment.go Show resolved Hide resolved

sunjayBhatia reviewed Nov 23, 2021

View reviewed changes

test/e2e/deployment/deployment_test.go Outdated Show resolved Hide resolved

stevesloka force-pushed the addDeploymentExample branch from abfdf67 to 1ba7616 Compare December 1, 2021 16:37

github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2021

stevesloka removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2021

sunjayBhatia self-requested a review December 16, 2021 21:47

skriss reviewed Jan 4, 2022

View reviewed changes

stevesloka added 12 commits January 7, 2022 13:45

Update scripts to generate an Envoy deployment style deployment

71b786c

Signed-off-by: Steve Sloka <slokas@vmware.com>

enable running e2e tests against envoy deployment style manifests

8dd9285

Signed-off-by: Steve Sloka <slokas@vmware.com>

add envoy deployment tests to pr ci builds

5d1b641

Signed-off-by: Steve Sloka <slokas@vmware.com>

add release note

43dff44

Signed-off-by: Steve Sloka <slokas@vmware.com>

add e2e tests for deployment style envoy

20a8c44

Signed-off-by: Steve Sloka <slokas@vmware.com>

add missing securityContext bits to deployment example

598d5f7

Signed-off-by: Steve Sloka <slokas@vmware.com>

remove debug line

ffb52f9

Signed-off-by: Steve Sloka <slokas@vmware.com>

change how a deployment is ready

1085f91

Signed-off-by: Steve Sloka <slokas@vmware.com>

copy httpproxy test to deployment e2e tests and refactor a bit

a054609

Signed-off-by: Steve Sloka <slokas@vmware.com>

review comments

4c23715

Signed-off-by: Steve Sloka <slokas@vmware.com>

rebase

0adcc3b

Signed-off-by: Steve Sloka <slokas@vmware.com>

rebase

218d63a

Signed-off-by: Steve Sloka <slokas@vmware.com>

stevesloka force-pushed the addDeploymentExample branch from 1ba7616 to 218d63a Compare January 7, 2022 20:00

fixup gingko imports

13c97a7

Signed-off-by: Steve Sloka <slokas@vmware.com>

skriss approved these changes Jan 7, 2022

View reviewed changes

skriss merged commit e1f295b into projectcontour:main Jan 11, 2022

skriss mentioned this pull request Jan 11, 2022

De-dupe E2E test code for Envoy deployment #4267

Closed

stevesloka deleted the addDeploymentExample branch January 12, 2022 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deployment example #4126

Add deployment example #4126

stevesloka commented Oct 20, 2021

codecov bot commented Oct 20, 2021 •

edited

Loading

stevesloka commented Oct 20, 2021

github-actions bot commented Nov 4, 2021

skriss left a comment

youngnick left a comment

stevesloka commented Nov 19, 2021

sunjayBhatia commented Nov 30, 2021

stevesloka commented Dec 1, 2021

github-actions bot commented Dec 16, 2021

skriss left a comment

skriss Jan 4, 2022

stevesloka commented Jan 7, 2022

skriss commented Jan 7, 2022

stevesloka commented Jan 10, 2022

sunjayBhatia commented Jan 10, 2022

Add deployment example #4126

Add deployment example #4126

Conversation

stevesloka commented Oct 20, 2021

codecov bot commented Oct 20, 2021 • edited Loading

Codecov Report

stevesloka commented Oct 20, 2021

github-actions bot commented Nov 4, 2021

skriss left a comment

Choose a reason for hiding this comment

youngnick left a comment

Choose a reason for hiding this comment

stevesloka commented Nov 19, 2021

sunjayBhatia commented Nov 30, 2021

stevesloka commented Dec 1, 2021

github-actions bot commented Dec 16, 2021

skriss left a comment

Choose a reason for hiding this comment

skriss Jan 4, 2022

Choose a reason for hiding this comment

stevesloka commented Jan 7, 2022

skriss commented Jan 7, 2022

stevesloka commented Jan 10, 2022

sunjayBhatia commented Jan 10, 2022

codecov bot commented Oct 20, 2021 •

edited

Loading