Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: check for nil condition in http requestUntil #3848

Merged
merged 1 commit into from
Jun 30, 2021
Merged

test/e2e: check for nil condition in http requestUntil #3848

merged 1 commit into from
Jun 30, 2021

Conversation

sunjayBhatia
Copy link
Member

  • condition might be nil when we dont think the request should succeed
  • return false if there is no condition

@sunjayBhatia
test/e2e: check for nil condition in http requestUntil
6ce0b1c 
- condition might be nil when we dont think the request should succeed
- return false if there is no condition

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner June 28, 2021 23:18
@sunjayBhatia sunjayBhatia requested review from stevesloka and skriss and removed request for a team June 28, 2021 23:18
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #3848 (6ce0b1c) into main (1d4526a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3848   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files         107      107           
  Lines        7344     7344           
=======================================
  Hits         5566     5566           
  Misses       1656     1656           
  Partials      122      122

@sunjayBhatia sunjayBhatia merged commit 11dcc95 into projectcontour:main Jun 30, 2021
@sunjayBhatia sunjayBhatia deleted the e2e-test-fix-panic branch June 30, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@youngnick youngnick youngnick approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunjayBhatia @skriss @youngnick