-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add troubleshooting page #3830
Add troubleshooting page #3830
Conversation
Signed-off-by: johnnycase <johneverettcase@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
- Coverage 75.83% 75.81% -0.03%
==========================================
Files 107 107
Lines 7338 7340 +2
==========================================
Hits 5565 5565
- Misses 1652 1654 +2
Partials 121 121
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit, overall looks like a good start to build out the different sections.
We might also want to include the FAQ (https://projectcontour.io/resources/faq/) page to link to or merge together someway.
Co-authored-by: Steve Sloka <steve@stevesloka.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks.
Ah, it looks like your most recent commit needs the signoff @johnnycase. Personally, I use It's actually better to do stuff locally rather than use the UI for this reason, sadly. Once the CI passes and the DCO is sorted, I'll merge this for you. |
i see, i'll make those edits and resubmit, thanks! I pushed the changes, I also found the same edit mentioned by Steve should be applied to two other pages, so I included those as well. Let me know if anything else is needed. |
Signed-off-by: johnnycase <johneverettcase@gmail.com>
Dang, it looks like the second commit here is still not signed off. In this case, it's okay, because I'm going to squash that one away anyway. Thanks very much! |
Thanks for merging! Sorry about the commit not being signed off. The command I used was git commit -s -m "Message" should I add anything there? |
site/content/docs: Add troubleshooting page
Created a troubleshooting page and added a troubleshooting section to the main Docs page.
Updates #3816
Signed-off-by: johnnycase johneverettcase@gmail.com