Fix:contour: error: expected argument for flag '--kubernetes-debug', try --help #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patil2099
requested review from
danehans and
youngnick
and removed request for
a team
…try --help Signed-off-by: Pankaj Patil <pankaj.patil2099@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3821 +/- ##
=======================================
Coverage 75.83% 75.83%
=======================================
Files 107 107
Lines 7338 7338
=======================================
Hits 5565 5565
Misses 1652 1652
Partials 121 121 |
|
Hello @Patil2099. Thanks. I reported #3810. @skriss asked me if I wanted to submit a PR to clarify this. We're still working on getting Contour deployed internally and I did not respond, but I can tell you that because of my lack of familiarity I would only have changed the one occurrence of this in one file, not your more comprehensive change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3810