Update compatibility docs and release cutting notes #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds release notes markdown template - Calls out in release process doc about what to include in release notes - Modifies notes in compatibility matrix to remove ambiguity - Minor updates in Philosophy document to bring it up to date Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
requested review from
skriss and
youngnick
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3796 +/- ##
=======================================
Coverage 75.83% 75.83%
=======================================
Files 107 107
Lines 7338 7338
=======================================
Hits 5565 5565
Misses 1652 1652
Partials 121 121 |
skriss
requested changes
Jun 10, 2021
There was a problem hiding this comment.
I think this looks good, just a couple nits. I'd suggest also updating https://github.com/projectcontour/contour#prerequisites to have more general language along the lines of "refer to the compatibility matrix for supported versions" so we don't have to remember to update it.
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
stevesloka
reviewed
Jun 10, 2021
|
Might need to also call out dropped support for Ingress v1beta1. I know it's removed from newer k8s versions, but could see users asking about this. |
- Clean up compatibility matrix text - Add a note to ingress doc about removal Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
skriss
approved these changes
Jun 11, 2021
danehans
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes