internal: Implement Envoy go-control-plane xDS Server #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the Envoy go-control-plane xDS Server as an option instead of the Contour built-in version configurable by the config file. Signed-off-by: Steve Sloka <slokas@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2845 +/- ##
==========================================
- Coverage 76.37% 75.32% -1.05%
==========================================
Files 74 76 +2
Lines 5832 5913 +81
==========================================
Hits 4454 4454
- Misses 1283 1364 +81
Partials 95 95
|
|
I was trying to make smaller commits to make it easier to review, but this never got in before I kept moving along. I'll just close this and use the other since it supersedes this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Envoy go-control-plane xDS Server as an option instead
of the Contour built-in version configurable by the config file.
Note: This doesn't actually serve up any resources, just implements the gRPC xDS server. Future PR will add that support.
Signed-off-by: Steve Sloka slokas@vmware.com