internal/dag: add more header condition validations #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2617 +/- ##
==========================================
+ Coverage 76.73% 76.77% +0.04%
==========================================
Files 71 71
Lines 5511 5538 +27
==========================================
+ Hits 4229 4252 +23
- Misses 1197 1199 +2
- Partials 85 87 +2
|
stevesloka
approved these changes
Jun 22, 2020
Detect additional invalid header condition scenarios and write them to the proxy's status, specifically for: - routes with both Exact and NotExact conditions with the same value for the same header - routes with both Contains and NotContains conditions with the same value for the same header Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
more-header-validations
branch
from
4d025a6 to
5b7ab28
Compare
|
fixed typo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2600 (comment) (specifically item 3).
Detect additional invalid header condition scenarios and write them
to the proxy's status, specifically for:
value for the same header
same value for the same header
Signed-off-by: Steve Kriss krisss@vmware.com