chore(grafana): configurable datastore #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
prometherion
approved these changes
Aug 30, 2023
|
Lgtm, let's align to the semantic commit messages to get it merged! I'd say |
aslafy-z
reviewed
Aug 30, 2023
| "text": "Prometheus", | ||
| "value": "Prometheus" | ||
| }, | ||
| "hide": 0, |
There was a problem hiding this comment.
Suggested change
| "hide": 0, | |
| "hide": 2, |
So the variable is hidden and the default Prometheus data source is selected
There was a problem hiding this comment.
I'd think it's better to have this variable visible. For example, one may want to switch between prometheus (with short term storage) and Thanos.
h4wkmoon
changed the title
True. Let me check. |
|
@h4wkmoon can we convert this from draft to ready for getting merged? |
oliverbaehler
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In grafana dashboard, prometheus datasource is hardcoded. This does fit every installation.
This PR make prometheus datasource a templating variable.